Exception when no root specified
flahertyb opened this issue · comments
Bart Flaherty commented
We're used to always having '/partners' - but when no root is specified (and it defaults to ""
), you get an invalid RegEx from this guy:
/**
@method _removeURIRoot
@param {String} uri '/partners/s/foo-bar'
@return {String} uri '/s/foo-bar'
**/
_removeURIRoot: function (uri) {
var rootRegex = new RegExp('^' + this.root);
return uri.replace(rootRegex, '');
}
Barnaby Claydon commented
Ah, yes, we definitely assume a prefix but should be straight forward to accommodate without.
Barnaby Claydon commented
@flahertyb were you able to work around/fix this? Would love if you were able to open a PR.
Bart Flaherty commented
ERROR: Permission to swipely/aviator.git denied to flahertyb.
fatal: Could not read from remote repository.
:(
Simon Højberg commented
@flahertyb oh i didn't realize. I added you as a collaborator now.