swimlane / ngx-charts

:bar_chart: Declarative Charting Framework for Angular

Home Page:https://swimlane.github.io/ngx-charts/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Drop dependency on rdfc? CommonJS dependency causes optimisation bailouts.

bonyjose opened this issue · comments

Describe the bug
Warning: @swimlane\ngx-charts\fesm2020\swimlane-ngx-charts.mjs depends on 'rfdc'. CommonJS or AMD dependencies can cause optimization bailouts.

To Reproduce
Steps to reproduce the behavior:

run the app that uses 'swimlane-ngx-charts', gets above warning at compile time.

Expected behavior
should compile without warning, potential missing optimisation.

Screenshots
image

ngx-charts version
20.4.1

Same here using Angular 17 and esbuild!

[WARNING] Module 'rfdc' used by 'node_modules/@swimlane/ngx-charts/fesm2020/swimlane-ngx-charts.mjs' is not ESM

CommonJS or AMD dependencies can cause optimization bailouts.
For more information see: https://angular.io/guide/build#configuring-commonjs-dependencies

Same here with Angular 17

Any updates here? same issue!!

Same here.

Thanks @PhilFlash for the work on the pull request - however is someone going to do a build of 21.0 so we can have this fix?

@marjan-georgiev Can you please review the linked PR by PhilFlash.