svg / svgo

⚙️ Node.js tool for optimizing SVG files

Home Page:https://svgo.dev/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Paths won't merge

MichaelHinrichs opened this issue · comments

Describe the bug
When I try to use SVGOMG to merge the paths in the attached SVG, two paths remain unmerged.
3DCommerce_Black_Aug20

To Reproduce

  1. Go to https://jakearchibald.github.io/svgomg/
  2. Open the attached SVG.
  3. Make sure the "Merge Paths' switch is on.
  4. Click "Markup" tab.

Expected behavior
All paths merge, leaving only one.

Screenshots
twopaths

Desktop (please complete the following information):

  • SVGO v3.0.0
  • Unknown NodeJs Version. Whatever SVGOMG is using.
  • OS: Windows 10

Additional context
I'm able to merge the paths with a text editor with no issue. The SVG looks exactly the same, so I'm not sure what's preventing SVGO from doing it. The original file comes from here, as well as others that may replicate the same problem.

It's not a bug. It's a desirable behavior. Unfortunately, it's not easy to implement. Merging paths can lead to issues like excluding sections. To avoid them one need to check for intersections or even path directions. Currently there is quick and dirty check for convex hulls intersections (by GJK algorithm). If you know a library that can do such a check for paths better than with O(n²) complexity, please let me know.