Giters

svg-sprite / svg-sprite

SVG sprites & stacks galore — A low-level Node.js module that takes a bunch of SVG files, optimizes them and bakes them into SVG sprites of several types along with suitable stylesheet resources (e.g. CSS, Sass, LESS, Stylus, etc.)

Home Page:https://github.com/svg-sprite/svg-sprite

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Update svgo to v3.x and csso to v5.x

XhmikosR opened this issue · comments

commented

https://github.com/svg/svgo/releases/tag/v3.0.0

We need to adapt our code too, PRs welcome!

EDIT: We should also update csso to v5.x after the svgo 3.x update, since svgo 3.x updated to that version too.

commented

@Kreeg I released v3.0.0-alpha1. After someone updates these two deps we can release a beta.

Then I think we have the regressions to fix, but unless someone provides a PR with tests and CC's us, not sure how we can fix those...

commented

Can I ask which regressions or remaining adaptations are still outstanding? I'm interested in contributing them if possible, but #773 passes CI so i'm unsure where to find the issues that arise from upgrading. Thanks in advance!

commented

@filoxo hello! Thanks for offering. There is no regressions or anything, this PR just needs a review from @XhmikosR.

commented

Released as v3.0.0-beta1. The new csso is quite bigger than 4.x but we can't do a lot about it.