Giters

svg-sprite / svg-sprite

SVG sprites & stacks galore — A low-level Node.js module that takes a bunch of SVG files, optimizes them and bakes them into SVG sprites of several types along with suitable stylesheet resources (e.g. CSS, Sass, LESS, Stylus, etc.)

Home Page:https://github.com/svg-sprite/svg-sprite

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Release 2.0 stable

Kreeg opened this issue · comments

commented

Remaining issues and opened PR's:

@XhmikosR hey! I think this is the final path to the stable release. We probably may skip this PR's and land 2.0 version without them. What do you think?

Fixes #697, #368

commented

Sorry, got busy with work and I forgot about this. I'd say we finish with the lodash issue (see my comment in #619) and we can probably release v2.0.0 stable. We'll just need to update the gulp/grunt packages too, but we'll see when it's time.

commented

Hi, any new developments?

commented

Hey.

Sorry, I got Covid recently and I'm slowly staring to come back to my daily routine. I haven't forgotten about this.

commented

Gosh, please take care of yourself.

commented

@XhmikosR please take care of yourself. This can wait as long as necessary. The health is the most important thing.

commented

@Kreeg could you maybe help out with the release notes? That's what's bugging me more, otherwise cutting a release is a matter of seconds :)

commented

@XhmikosR yes, of course. I'll do it tonight

commented

UI and CLI updates:

  • Added namespaceIDPrefix option
  • Added rel="noopener noreferrer" to all links in generated HTML pages.
  • Added compileAsync method
  • Added support for disabling root viewBox attribute in stack mode
  • Added ID references substitution in href attributes (earlier worked with xlink:href only)
  • Dropped support for Node version < 12
  • Removed deprecated transform option
  • Added milliseconds in logger's output
  • Changed SVG dimensions calculation from phantomjs to resvg-js, dropped PhantomJS direct dependency (replaced with resvg-js)
  • Fixed rare issue with valid svg files marked as invalid
  • Fixed rare bug with checking if passed config.log option is an instance of winston.Logger
  • Fixed missing shape names when adding input files with a relative path

Dev updates

  • All packages (dev and direct) are up-to-date (except for playwright)
  • Added code linting (XO)
  • Replaced mocha + should + c8 with jest test runner
  • Replaced PhantomJS + image-diff with playwright + pixelmatch as for regression tests
  • A lot of docs tweaks
  • Massively reduced lodash and other direct dependencies. Switched to native js alternatives
  • A lot of code refactoring.
    • Massively switched to async methods whenever possible.
    • Switched to ES6 classes whenever possible
    • Fixed JSDoc documentations
  • Added regression tests for svgs without dimensions
  • Added regression tests for all modes
  • Added tests and coverage reports to CI (linux, windows support.).
  • Added unit tests
  • Added dependabot
  • Replaced cssmin with csso

@XhmikosR I hope I covered it all. Pls check on typo and grammar :D

commented

@XhmikosR hello! Can we land the release? Or should I update changelogs?

commented

Any news on this? Is everyone ok?

commented

Sorry for the lack of reply, I missed the notifications. I'll take of it soon, but perhaps after #734 since Node.js is pretty old and we are going to make a new major version now.

I'll use @Kreeg's release notes above as a basis.

commented

NVM, I'll release v2.0.0 now and we can make a v3.0.0 later.

commented

Whohoo!