wrong dimensions and color

Question

wrong dimensions and color

tanmay1978 opened this issue 9 years ago · comments

Tanmay Arun Navghare commented 9 years ago

An icon of dimension 40x40 when added to sprite it renders it as 50x50

Another issue is with the color. If I have a svg icon of white when that is added to the sprite it defaults to black. But that is beacause a class is added to all the svg elements and that class is overriden for other icons in the sprite. Is that a way to eliminate the use of css styles that it applies by default?

Joschi Kuphal · Answer 1 · Mon Sep 07 2015 22:20:46 GMT+0800 (China Standard Time)

Hey @tanmay1978,

regarding the dimension issue, please post your complete configuration for the transformation.

Regarding the color: Please follow this thread for an explanation (and possible solution).

Cheers, Joschi

Tanmay Arun Navghare · Answer 2 · Mon Sep 07 2015 22:39:35 GMT+0800 (China Standard Time)

Hi the grunt config is as follow

// Make SVG sprite images from input svg icons
        svg_sprite : {
            your_target : {
                cwd         : paths.images.srcIcons,
                src         : '*.svg',
                dest        : paths.images.staticImages,
                options                 : {
                    shape               : {
                        spacing         : {
                            padding     : 5
                        }
                    },
                    mode                : {
                        view            : {
                            bust        : false,
                            render      : {
                                scss    : {
                                    dest    : '_sprite'
                                }
                            }
                        }
                    }
                }
            }
        },

Joschi Kuphal · Answer 3 · Mon Sep 07 2015 22:55:05 GMT+0800 (China Standard Time)

So the dimension increase from 40 to 50 pixels is a logical result of your shape.spacing.padding = 5 option, as shape.spacing.box defaults to "content". Please see the documentation for all details about this.

Did you follow the other thread regarding the CSS issue.

As I don't see any error in svg-sprite's behavior here I'll close this issue for now. Please feel free to re-open it in case of any further real errors.

Cheers, Joschi

Tanmay Arun Navghare · Answer 4 · Mon Sep 07 2015 22:56:10 GMT+0800 (China Standard Time)

Thanks will check and confirm

Tanmay Arun Navghare · Answer 5 · Mon Sep 07 2015 23:05:58 GMT+0800 (China Standard Time)

I just checked if I use shape.spacing.box then the sprites are generated with no spacing between them and still the dimensions vary by 10px

Joschi Kuphal · Answer 6 · Tue Sep 08 2015 03:22:28 GMT+0800 (China Standard Time)

What value did you set for shape.spacing.box?

Tanmay Arun Navghare · Answer 7 · Tue Sep 08 2015 14:17:13 GMT+0800 (China Standard Time)

it was set to "content"

[image: --]

Tanmay Arun Navghare
[image: https://]about.me/tanmayarunnavghare
https://about.me/tanmayarunnavghare?promo=email_sig

On Tue, Sep 8, 2015 at 12:52 AM, Joschi Kuphal notifications@github.com
wrote:

What value did you set for shape.spacing.box?

—
Reply to this email directly or view it on GitHub
#59 (comment)
.

Joschi Kuphal · Answer 8 · Tue Sep 08 2015 14:52:49 GMT+0800 (China Standard Time)

So you didn't change anything? Then, of course, the behavior wouldn't change. Again, please read the relevant documentation section to understand the available options and how to use them. Thanks.