Giters

svg-sprite / grunt-svg-sprite

SVG sprites & stacks galore — Grunt plugin wrapping around svg-sprite that reads in a bunch of SVG files, optimizes them and creates SVG sprites and CSS resources in various flavours

Home Page:https://github.com/svg-sprite/svg-sprite

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Sprite url attribute not escaped in templates.

losadaem opened this issue · comments

commented

If you are in a windows environment the sprite attribute is not escaped in templates. So if you are using a relative path the sprite attribute contains backslashes.

One solution is to provide an escaped_sprite version.

commented

Hi @losadaem,

thanks for your report. Unfortunately, I don't have a Windows environment ready for testing these things (in fact, I never tested any of the svg-sprite or iconizr modules on Windows), and also I'm currently pretty overloaded, so it will take me a while to work on this issue. Please hold on!

Cheers,
Joschi

commented

Hi @losadaem,

could you please provide an example regarding this problem? What are your input / config parameters, and what is the output (CSS / Sass / LESS etc. files)? I still don't have a Windows setup, but I could try to bugfix this blind flying ...

Thanks

commented

Hi @losadaem,

although you never responded to my question: I just published the next major release of grunt-svg-sprite. It's rewritten from scratch and possibly your issue is no issue any longer — could you please check this? I'll close the issue for now, but please feel free to re-open it in case you've still got problems.

Cheers & a happy new year,
Joschi

commented

Hi @jkphl,

Sorry, I forgot completely this issue. The developer that was using it on Windows has switched also to a Mac system so we can't check this now. I don't think we are going back to a Windows environment.

In Mac we are using your plugin for a while and we have no problems. Thank you very much for your work.

Happy new year too,

Emilio

commented

Glad you get along! :)