Giters

svenstaro / rofi-calc

🖩 Do live calculations in rofi!

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Mode broken in 1.7.3

VersusF opened this issue · comments

commented

Hello
After updating to rofi 1.7.3 I get a syntax error as it expects a "(" after the calc keyword.
My hypotesis is that calc is a reserved word to perform calculations and it is not seen as a mode.

Here is the configuration:

configuration {
	show-icons: true;
	icon-theme: "Tela-dark";
	modi: [drun,filebrowser,run,calc];
	combi-modi: [file-browser,drun,calc];
	display-drun: "Run";
	display-calc: "Calc";
	display-run: "Exec";
	display-file-browser: "Explore";
}
@theme "theme.rasi"

Let me know if you need additional info.
Thanks a lot!

commented

Hm weird, I'm currently using rofi 1.7.3 and rofi-calc works without a hitch. I'm not really sure what's wrong here. I even just recompiled rofi-calc against it to verify.

commented

My config is this:

configuration {
    show-icons: true;
    matching: "fuzzy";
    sort: true;
    sorting-method: "fzf";
}
@theme "/usr/share/rofi/themes/gruvbox-dark.rasi"

and I start rofi-calc using rofi -show calc -modi calc -no-show-match -no-sort.

commented

Thanks for the quick reply.
If I specify the modi in the CLI it works as intended. The problem is when I specify the modi in the config file.

I run rofi with rofi -show drun so that it takes the modi from the config file. The problem is the file parsing.

A good workaround may be to specify all the modi in the command (usually bound to a keyboard shortcut).
I just wanted to report the "broken configuration file" problem, in case someone else have the modi specified in the rasi configuration file

commented

Hm, is this perhaps a thing you should bring to the attention of rofi upstream? I'm not sure this should be hacked somewhere in rofi-calc.

commented

calc has become a keyword a while back, and recently lists (for the tabstop) supports distances (that contain the calc keyword). This caused the issue here.

I've added a fix to git that hopefully resolves it (but this makes the parser needs to consider 2 branches until resolved) and I would prefer if it can be tested by more then just me :D

commented

You can just wrap your modis in quotes, i.e.
modi: ["drun", "filebrowser", "run", "calc"];

commented

All in all I think we can stop treating this like an issue in rofi-calc?

commented

@svenstaro I mean... it's not an issue at all if it can be solved by a couple of quotation marks

commented

Would be great if someone could add a hint on the README or wiki so others don't fall into this. :)

commented

or somebody can confirm the fix I added to git fixes it and I can make a new rofi release?