sveltejs / svelte-preprocess

A ✨ magical ✨ Svelte preprocessor with sensible defaults and support for: PostCSS, SCSS, Less, Stylus, Coffeescript, TypeScript, Pug and much more.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

"Generic type 'Options<sync>' requires 1 type argument(s)" error on `Sass` type

DetachHead opened this issue · comments

Describe the bug

> tsc
node_modules/svelte-preprocess/dist/types/options.d.ts:29:33 - error TS2314: Generic type 'Options<sync>' requires 1 type argument(s).

29 export declare type Sass = Omit<SassOptions, 'file' | 'data'> & {
                                   ~~~~~~~~~~~


Found 1 error in node_modules/svelte-preprocess/dist/types/options.d.ts:29

To Reproduce

import preprocess from 'svelte-preprocess'

Expected behavior
no error

Information about your project:

  • svelte-preprocess version 4.10.7

Additional context
workaround is to enable skipLibCheck in tsconfig, which isn't ideal

I at a loss trying to imagine how a critical type error such as this could make it into production.

my guess is because this project uses ts-jest which has a critical issue where it skips most type checking

Hey @DetachHead 👋 this will hopefully be fixed in #562.

I at a loss trying to imagine how a critical type error such as this could make it into production.

This is more related to the installed sass version than anything else. At some point, sass changed the signature of the Options type, so here we are.

I've published 5.0.0@next can you try with it?

I've published 5.0.0@next can you try with it?

it works, thanks!