suzaku-io / boopickle

Binary serialization library for efficient network communication

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Remove PicklerGenerator in DefaultBasic object

cornerman opened this issue · comments

In the Default object, we have the implicit method generatePickler directly available. Differently, the DefaultBasic object has an inner object PicklerGenerator with a generatePickler method. I find this little difference cumbersome when switching between import Default and DefaultBasic in a file, sometimes it needs import PicklerGenerator._, sometime not.

Can we remove the PicklerGenerator object and move the method into the DefaultBasic object?

Yeah, I'm not sure if there was a reason for this, or if it's just some historical artifact. Probably the latter, so I'm open to unifying them :)