Fix and improve tests

Question

Fix and improve tests

sehwol opened this issue 4 years ago · comments

sehwol commented 4 years ago

Fix broken tests
Split single test that tests all languages into parameterized tests that test 1 word only

Deleted user · Answer 1 · Sat Sep 05 2020 00:57:09 GMT+0800 (China Standard Time)

Ok. Please do comment if the tests pass/fail on your machine.

Suyash · Answer 2 · Sat Sep 05 2020 01:16:26 GMT+0800 (China Standard Time)

Tests are indeed failing on my machine, I'll probably add mocks that serve local copies of the HTML later

Deleted user · Answer 3 · Sat Sep 05 2020 01:22:15 GMT+0800 (China Standard Time)

I'll rebase the testingOutput.json commits.

Tests are indeed failing on my machine,

Sorry, are the tests failing on the pull-request branch or master?

I'll probably add mocks that serve local copies of the HTML later

I'd like to take care of this. So do you think it would be a good for me to create a script that:

Downloads the necessary HTML files for testing into the repo.
Save them as part of the repo.
?

Suyash · Answer 4 · Sat Sep 05 2020 01:35:36 GMT+0800 (China Standard Time)

Tests are indeed failing on my machine,

Sorry, are the tests failing on the pull-request branch or master?

Should've been more specific. I meant they're failing on master.

Sure we can have a test utility script that downloads the HTML and saves it as a part of the repo whenever a new test word is added. We'll also have to mock session.get to read these HTML files and return them instead