Giters

sustcast / sustcast-android-app-v1

📻 Android Application for SUSTcast [Online Radio Station]

Home Page:https://tinyurl.com/sustcast

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Internet Unavailable PopUp

shuhanmirza opened this issue · comments

commented
Internet Unavailable PopUp
commented

Added an internet checker to LandingActivity.
Why LandingActivity only?

  • It only made sense because authChecking will be happening in SplashActivity anyway and on failure will be returned to LandingActivity. So in case of internet failure, it will go to that specific activity.

@shuhanmirza Please close the issue if you are satisfied with the approach.

commented

I think we should have a helper function. So that we can check connectivity from any activity. And if connectivity is not present, a dialog popup will be shown or every activity will just be directed to the landing activity.

Sounds right?

commented

Yes, I did that. But is it necessary to check this in every activity that gets redirected from LandingActivity as it's the parent layout anyway? by every activity, I meant LoginActivty SignUpActivity and others.
Make an issue for @appledora if you want it to be used in her fragments too.

commented

Let's discuss this on next meeting.

commented

Closing issue.