Giters

sustainablecomputinglab / solar-tk

Solar-TK Modeling and Forecasting Toolkit

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Southern hemisphere tilt calculation

steeled opened this issue · comments

commented

Let me start by saying thank you for sharing!

I was experimenting a little with this project with the AusGrid solar dataset. I seem to run into an issue in the get_tilt function. It seems like southern hemisphere latitudes cause some issues (for example, -33.7085861, 151.1228434).. or at least the negative tilt fails validation in the maximum_generation module. Grateful for any suggestions or advice.

commented

I think it might be a simple fix by taking the abs(self.lat_) in the find_parameters func.:
best_tilt = math.radians(self.lat_) -> math.radians(abs(self.lat_))
I also set 'best_ori' to 0:
best_ori = math.radians(0)

commented

thanks for pointing out the issue and suggesting a fix. I will merge it to the source.
apologies for the delayed response, I was not getting email notifications.