[Suggestion] Linting problem

Question

[Suggestion] Linting problem

vjancik opened this issue 8 years ago · comments

There's an issue with ESLint: eslint/eslint#6001 eslint/eslint#5679

and using this causes the linter to run for over 10 seconds (if your node_modules are populated, on OS X for sure, not sure what other platforms) .
I solved it by changing it to:
"lint": "eslint ./app --ext .js --ext .jsx --cache",

You may consider adding webpack.config.js too to replicate original behavior.

Juho Vepsäläinen · Answer 1 · Mon May 02 2016 00:26:50 GMT+0800 (China Standard Time)

Thanks. This chapter is going to the webpack book really soon. I've added --cache to the dev version there.

I'll close this once that has been published.

Viktor Jančík · Answer 2 · Mon May 02 2016 00:33:58 GMT+0800 (China Standard Time)

The problem is in the dot . not in --cache. Replace . with ./app. Sorry if I just said the obvious, from your response it seemed like you missed the point.

Juho Vepsäläinen · Answer 3 · Mon May 02 2016 00:42:33 GMT+0800 (China Standard Time)

Missed the point, yeah. Thanks for highlighting that.

Juho Vepsäläinen · Answer 4 · Tue May 03 2016 20:37:39 GMT+0800 (China Standard Time)

I'm tracking eslint/eslint#5679 . If they can resolve the issue, perhaps the book doesn't need an update for this after all.

Juho Vepsäläinen · Answer 5 · Mon May 30 2016 23:36:06 GMT+0800 (China Standard Time)

Solved at dev. Given the release is so near, closing.

Juho Vepsäläinen · Answer 6 · Wed Jun 01 2016 00:55:08 GMT+0800 (China Standard Time)

@vjancik Looks like they did a fix. See eslint/eslint#5679 . That could help. 👍