Incorrect tuning in some locales

[JP Cimalando]

Hello,

If the programs sets a C locale which prefers comma as decimal separator, the file is misread and gives wrong results.

If you trace this portion of code as follows.

t.cents = atof(line.c_str());
fprintf(stderr, "CONVERT \"%s\" to %f\n", line.c_str(), t.cents);

You may observe either of the following results depending on the program's locale.

CONVERT " 76.04900" to 76.049000
CONVERT " 76.04900" to 76,000000

[Paul]

Oh thank you! I will add locale aware parsing to these parts of the code base this week.

Appreciated.

[Paul]

Oh and @jpcima I made this library because I copied the surge library for our branch of dexed. On my list for the immediate future is to rip out our dexed tuning implementation and replace it with this as a submodule of course.

[Paul]

float longitude = 0.0f;
std::istringstream istr(pField);

istr.imbue(std::locale("C"));
istr >> longitude;

Is what I need; plus some regtests where I run in a European locale

[JP Cimalando]

This, I also believe, is the simplest portable fix of this problem.

This is great, thanks! We will likely add this library into Sfizz to provide some tuning options.

[Paul]

Oh excellent - here's a retest which fails in the current lib. Cool will be easy to fix now.

    SECTION( "Test All Constraints SCL and KBM in Spain" )
    {
        std::locale::global( std::locale( "es_ES" ) );
        for( auto fs: testSCLs() )
            for( auto fk : testKBMs() )
            {
                INFO( "Testing Constraints with " << fs << " " << fk );
                auto s = Tunings::readSCLFile(testFile(fs));
                auto k = Tunings::readKBMFile(testFile(fk));
                Tunings::Tuning t(s,k);
                
                for( int i=0; i<127; ++i )
                {
                    REQUIRE( t.frequencyForMidiNote(i) == t.frequencyForMidiNoteScaledByMidi0(i) * Tunings::MIDI_0_FREQ );
                    REQUIRE( t.frequencyForMidiNoteScaledByMidi0(i) == pow( 2.0, t.logScaledFrequencyForMidiNote(i) ) );
                }
            }
        std::locale::global( std::locale( "" ) );
    }

[Paul]

This is great, thanks! We will likely add this library into Sfizz to provide some tuning options.

Awesome! That's why we factored it and MIT licensed it!

[Paul]

OK I just pushed a fix to master, including a regtest. The regrets actually exposed another locale bug so I fixed that too.

Please give it a whirl! And if you can check if 'make alltests' works for you in your locale that would be great.

If it's all OK please close the issue.

And lemme know how it goes!

[JP Cimalando]

It works well ! Thank you