Giters

surface-ui / surface

A server-side rendering component library for Phoenix

Home Page:https://surface-ui.org

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Surface.LiveViewTest is broken after Phoenix LiveView 0.20.15

crova opened this issue · comments

commented

Describe the bug

Surface.LiveViewTest is broken after Phoenix LiveView 0.20.15.

They removed live_component/{2,3} from the Phoenix.LiveView.Helpers (changelog here) which Surface.LiveViewTest depends on.

Whenever we use Surface.LiveViewTest we'll get something like:

warning: cannot import Phoenix.LiveView.Helpers.live_component/3 because it is undefined or private
use Surface.LiveViewTest

How to reproduce it

  1. Bump LV to 0.20.15 or higher and use Surface.LiveViewTest on any test.

I'm not sure what would be the best solution here but I'm open to help in any capacity I can.

In any case, thanks for the great library :)

commented

Closing in favor of opened PR.