dialyzer complains since v0.8.2
dvic opened this issue · comments
Since e8aea39, I'm getting dialyzer errors across my project in the form of
lib/my_web/some_file.ex:1:pattern_match
The pattern can never match the type.
Pattern:
false
Type:
true
Unfortunately I can't reproduce it but commenting out those lines indeed fixes the problem!
I found a solution: add generated: true
to the quote
call and Dialyzer ignores it :)
Now the question is: should all of the AST generated by Surface have generated: true
or do we just add it to this part?
@dvic Thanks! Adding generated: true
makes sense there. I wonder why we're not getting any warning on our tests.
Anyway, I think we should add it only to this part, for now. Would you be willing to submit a PR with that fix?
Sure, will do 👍!