dialyzer complains since v0.8.2

Question

dvic opened this issue 2 years ago · comments

Since e8aea39, I'm getting dialyzer errors across my project in the form of

lib/my_web/some_file.ex:1:pattern_match
The pattern can never match the type.

Pattern:
false

Type:
true

Tiago Moraes · Answer 1 · Sat Sep 17 2022 08:31:22 GMT+0800 (China Standard Time)

@dvic I suspect it's these lines but couldn't reproduce it, can you create a repo with this issue?

Damir Vandic · Answer 2 · Sat Sep 17 2022 14:52:27 GMT+0800 (China Standard Time)

Unfortunately I can't reproduce it but commenting out those lines indeed fixes the problem!

Damir Vandic · Answer 3 · Sat Sep 17 2022 20:35:01 GMT+0800 (China Standard Time)

I found a solution: add generated: true to the quote call and Dialyzer ignores it :)

Now the question is: should all of the AST generated by Surface have generated: true or do we just add it to this part?

Marlus Saraiva · Answer 4 · Sat Sep 17 2022 21:01:25 GMT+0800 (China Standard Time)

@dvic Thanks! Adding generated: true makes sense there. I wonder why we're not getting any warning on our tests.

Anyway, I think we should add it only to this part, for now. Would you be willing to submit a PR with that fix?

Damir Vandic · Answer 5 · Sun Sep 18 2022 01:02:14 GMT+0800 (China Standard Time)

Sure, will do 👍!