supabase / auth

A JWT based API for managing users and issuing JWT tokens

Home Page:https://supabase.com/docs/guides/auth

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Invalid HELO message for smtp relays - w/Solution Proposal

saschTa opened this issue · comments

Bug report

  • I confirm this is a bug with Supabase, not with my own application.
  • I confirm I have searched the Docs, GitHub Discussions, and Discord.

Describe the bug

Supabase Auth uses supabase/mailme with gomail for sending emails over external smtp servers.

Gomail uses localhost as default HELO message which gets rejected by some smtp providers. (gmail smtp relay e.g.)
Gomail might change that behaviour but I think supabase should not use a default value here.
go mail pr

Additional context - Linked Issue

I created an issue on supabase general already since I was not sure where the culprit was located.
After some digging I found the issue in mailme which is used by supabase/auth

I link the issue here and the pr in mailme for sake of completeness. Please let me know if we should move the issue here or to mailme.

Issue

PR for mailme

closing this issue since we've bumped the mailme package in this PR which contains the changes you've made!