add snapshots test back to `parser`

[Philipp Steinrötter]

Planned Work

We already had it in place but dropped it because it's unnecessary now that the parser panics on invalid statements. but turns out it's actually quite useful when reviewing pull requests for #51. we should add it back using insta as before. we should be able to simply copy it from the git history of the statement_parser_test file.

[Cedric Vangout]

Yeah, I was exactly thinking about this, having insta back will help making PRs related to #51 less tedious. Another great addition could be testing against postgres regression tests as well

[Philipp Steinrötter]

Another great addition could be testing against postgres regression tests as well

ohh thats a great idea! we can just copy the sql files, or add the entire postgres repo as a submodule to keep it up-to-date. wdyt?

[Cedric Vangout]

I was planning at first to pull the sql files with a tiny script and later add it as a submodule when progress has been made

[Philipp Steinrötter]

@cvng can you open a separate issue for pulling in the regression tests?

[Cedric Vangout]

@psteinroe sure, I already had a few PRs stacked for #51, so I will proceed to pull the postgres tests once those are merged

EDIT: also, should we somehow consolidate parser e2e & unit tests? eg. add get_node_properties in the snapshots

[Philipp Steinrötter]

EDIT: also, should we somehow consolidate parser e2e & unit tests? eg. add get_node_properties in the snapshots

the get_node_properties tests should rather serve as a help for devs to figure out the right props fast - I would keep them separated.