Supporting :keystore-scan-interval like the main Jetty adapter

Question

Supporting :keystore-scan-interval like the main Jetty adapter

TuggyNE opened this issue 3 years ago · comments

Looks like Ring's bundled Jetty adapter supports a useful option, :keystore-scan-interval, which allows updating certificates without restarting the server. Seems like the code for it is pretty simple, although I haven't tried building from source yet so I don't have an easy way to test it. Thoughts on pulling that in?

Ning Sun · Answer 1 · Wed Jun 30 2021 23:05:48 GMT+0800 (China Standard Time)

That will be a good addition. Will you send a pull request for that?

Dimitrios Piliouras · Answer 2 · Tue Mar 28 2023 02:21:35 GMT+0800 (China Standard Time)

This is now supported (after merging #91), or rather, automatically happening so this ticket could be closed.

Dimitrios Piliouras · Answer 3 · Thu Apr 27 2023 02:55:27 GMT+0800 (China Standard Time)

@sunng87 Now that we rely on Jetty's KeyStoreScanner, it is trivial to support a keystore-scan-interval option, and propagate it down to the .setScanInterval call (which now hardcodes 3600). I would have done this in my PR, but I completely forgot about this issue... :(

For reference:
https://github.com/ring-clojure/ring/blob/master/ring-jetty-adapter/src/ring/adapter/jetty.clj#L125