sunng87 / ring-jetty9-adapter

An enhanced version of jetty adapter for ring, with additional features like websockets, http/2 and http/3

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

docstring for handler in run-jetty doesn't match api

mpenet opened this issue · comments

the handler keys functions should be

{:on-connect (fn [ws])
   :on-close (fn [ws])
   :on-error (fn [ws e])
   :on-text (fn [ws msg])
   :on-byte (fn [ws bytes offset length])}

right now they mention create-fn etc, following a different naming scheme.

I might throw a PR when I get some free time.
Thanks for this adapter btw, very useful.

Cheers

not relevant if #14 is merged

Thanks. I will merge your #14 to fix this.

close as #14 merged.