sunng87 / handlebars-rust

Rust templating with Handlebars

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Reuse `RenderContext` after executing partial

gemhtcr opened this issue · comments

For now, because of the following line of code, handlebars doens't share RenderContext when rendering partial.

https://github.com/sunng87/handlebars-rust/blob/9d7d5556287e31e4148841a56e0981b64a679fb6/src/partial.rs#L61C9-L61C39

  // Rust
 let partial = find_partial(rc, r, d, tname)?; 
  
 if let Some(t) = partial { 
     // clone to avoid lifetime issue 
     // FIXME refactor this to avoid 
     let mut local_rc = rc.clone();    // <---  This line can't reuse `RenderContext` after partial
  
     // if tname == PARTIAL_BLOCK 
     let is_partial_block = tname == PARTIAL_BLOCK; 
  
     // add partial block depth there are consecutive partial 

Is it possible to fix it and have a universal RenderContext when rendering ?

Yes because partial has its own context data. I'm curious about your use case for reusing the RenderContext.

Hi @sunng87 , thanks for your update

My case is that I have an assign helper to assign things to some variable. See below

// _partial.hbs
...
{{#assign "foo"}}
bar
{{/assign}}
...
// parents.hbs 
...
{{> _partail}}
...
{{foo}}       <---- expected to show "bar"

After spending time tracing source, it seems to me the closest solution is to add it into RenderContext so that it can be seen by parent context
I'm happy to learn if there is other way to achieve this

I think it's not possible also it's not recommended to have data modification in templates, which has poor debug experience. I will suggest you to prepare the data ahead of rendering and feed to the template directly.