sul-dlss / vt-arclight

An Arclight-based discovery application for materials from the Virtual Tribunals project

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Remove parent container attribute in search result view for every level

ggeisler opened this issue · comments

commented

Unless I'm missing something, these links in search result items don't actually do anything other than refresh the current page:

Screen Shot 2023-01-11 at 2 39 24 PM

This isn't good because by offering the link we're basically telling the user there is something useful they'll see if they follow this link, but then we don't show them anything useful. So it's kind of false advertising and confusing.

If this is just a bug and we expect to produce something different (I'm not certain what the intention was, since it's different from the original design, now updated in #461), we should fix it.

If there's just a technical hurdle where we can't show a new page based on the parent item that is linked, we should just unlink the parent container label, leaving it displayed but unlinked.

Longer-term, my hope is this attribute actually goes away completely and is replaced by the attributes suggested in #461.

Just some notes on a first pass over looking at this:

#161 is where the linking concept seemed to come from, and this is the PR #178

Here is where we attempt to render the link:

config.add_index_field 'parent_ssi', component: MetadataAttributeComponent, helper_method: :render_parent_link

We should probably try to debug that helper.

don't show it at all actually -- after discussion with Gary.