suisei-cn / starbuttons

☄️ Vocal buttons for Suisei.

Home Page:https://suisei.cc

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Find a better alternative of { outline: none; }

outloudvi opened this issue · comments

In 363a73d we removed outlines for focused elements due to design considerations. Since we have aria-label stuffs, we thought that the removal of outline would not affect accessibility a lot. However, as said by http://outlinenone.com/, it DOES have a huge effect on a11y. As a site that stresses a11y, we need to find a alternataive of outline.

Hello! I'd recommend keeping the outline for keyboard focus but if it's decided to keep them out for design purposes - change the design for an incredibly visible focus indicator (i.e. change background color on focus + hover)

How to Design Useful and Usable Focus Indicators

Hope this helps! Have a great weekend

Thanks for your suggesstion, @stroudn1! We are also considering the visible focus indicator. Changing background color is a good idea. Also, currently we bold the text on hovering, so maybe we can just copy the :hover behaviour to :focus.