subspacecommunity / subspace

A fork of the simple WireGuard VPN server GUI community maintained

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

The 1.5.0 Docker tag is the same as 1.3

syphernl opened this issue · comments

commented

Describe the bug
After upgrading to 1.5.0 (image: subspacecommunity/subspace:1.5.0), which should contain TOTP settings, I am not seeing anything new.
No TOTP is being shown for the "local" admin account nor the one authenticated through SAML.

Digging through the code of the commit (#126) I see there also should be an /totp/image endpoint but this is returning 404 page not found.

To Reproduce
Steps to reproduce the behavior:

  1. Run subspacecommunity/subspace:1.5.0
  2. Login, go to settings
  3. No TOTP settings shown

I can confirm that pulling from dockerhub results in totp not being enabled. However, cloning and compiling subspace from source shows that the feature is indeed in the master branch... curious

@agonbar do you have any idea what could have gone wrong with the dockerhub integration?

image

A check fails, but I don't have access to dockerhub so I cant really see what went wrong. However the image was updated succesfully, at least for x86_64 devices, so I don't know where to start looking for a flaw.

I wonder if triggering another release would cause the image to be updated with the correct code, but I don't want to play around with productive assets.

@syphernl in the meantime you can compile the master branch. That will provide you the correct code until I can find what went wrong with publishing the docker image.

@agonbar Indeed as pointed out by Elbert Lai in slack, dockerhub is pulling an old hash
image
image

both have the same hashes

@syphernl just found out that the tag amd64-v1.5.0 is working as intended. Please use that until we fix and update the shorthand tags

It is fixed?

@syphernl just found out that the tag amd64-v1.5.0 is working as intended. Please use that until we fix and update the shorthand tags

Any update on docker tag issue?