sublimelsp / LSP

Client implementation of the Language Server Protocol for Sublime Text

Home Page:https://lsp.sublimetext.io/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Prepare for upgrade of bracex and wcmatch libraries

deathaxe opened this issue · comments

If the dust has settled with transitioning to python 3.8, two PRs are prepared to upgrade

by shipping them directly from pypi for python 3.8

I already installed them manually and haven't seen any negative impacts so far. Maybe someone more involved could double check for possible incompatibilities, especially as version numbers of wcmatch differ significantly.

bracex is used by wcmatch
wcmatch still exposes the same API that LSP uses.
The behavior might be different however.

Do you maybe have a guide on how to install those deps locally?

You can download the whl files and directly extract them into ST's Lib/python38 folder.

Make sure to remove the currently installed libraries' folders first.

I will start with testing this.

If someone want to also try to test it out.
You would need to keep the bracex-2.1.1.dist-info and wcmatch-1.2.1.dist-info
and change the INSTALLER to not point to Package Control

I have't run into any issues in the past two weeks.

I will close this issue, because there are no code changes that needs to be done on the LSP side,
and I haven't noticed any regressions.

Feel free to reopen this is you think otherwise.