1.5.0+ is incompatible with Sublime Text 3
Narretz opened this issue · comments
Ever since the findCallers functionality was introduced, the plugin is not compatible with Sublime Text 3 anymore, because the ST3 version of LSP doesn't have a lot of exports used by LSP-typescript.
See the protocol.py in this commit: bc814ef#diff-0b549f1c0f3a521812a4528e268dfa59241bac5f2e69ff8a3c745f75a7fdc981
And the corresponding LSP.plugin.core.protocol at the latest ST3 version: https://github.com/sublimelsp/LSP/blob/3154-0.14.3/plugin/core/protocol.py
Since I don't see anything official about ST3 support being dropped, I think this should be fixed.
Possible solutions:
- different releases for ST3 and ST4
- make the new features compatible with ST3
- disable the new features in ST3
- drop support for ST3
I'll create a new branch and new release for ST3 from an older commit as I don't want to spend effort on maintaining ST3 support.
Works for me, thanks!
ST3-compatible should appear in about 2h from now.
Hi @rchl the release is on package-control but the commit it's built from points to (then) master which means it's basically the same as 1.8.0:
Release: https://github.com/sublimelsp/LSP-typescript/releases/tag/st3-1.9.0
Commit: 59b6092
Thanks for catching that. Fixed now.