Giters

sublimelsp / LSP-pyright

Python support for Sublime's LSP plugin provided through microsoft/pyright.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Crashes in ST3

rchl opened this issue · comments

commented

It might be happening only with PC4 but not entirely sure. This code crashes:

LSP-pyright/plugin.py

Lines 164 to 182 in 8eb4231

def find_package_dependency_dirs(self, py_ver: Tuple[int, int] = (3, 3)) -> List[str]:
dep_dirs = sys.path.copy()
# replace paths for target Python version
# @see https://github.com/sublimelsp/LSP-pyright/issues/28
re_pattern = r"(python3\.?)[38]"
re_replacement = r"\g<1>8" if py_ver == (3, 8) else r"\g<1>3"
dep_dirs = [re.sub(re_pattern, re_replacement, d, flags=re.IGNORECASE) for d in dep_dirs]
# move the "Packages/" to the last
# @see https://github.com/sublimelsp/LSP-pyright/pull/26#discussion_r520747708
dep_dirs.remove(ST_PACKAGES_PATH)
dep_dirs.append(ST_PACKAGES_PATH)
if py_ver == (3, 3):
# sublime stubs - add as first
dep_dirs.insert(0, os.path.join(self.package_storage(), "resources", "typings", "sublime_text"))
return [path for path in dep_dirs if os.path.isdir(path)]

with:

Traceback (most recent call last):
  File "/Applications/Sublime Text 3.app/Contents/MacOS/sublime_plugin.py", line 298, in on_api_ready
    plc()
  File "/Users/rafal/Library/Application Support/Sublime Text 3/Installed Packages/LSP.sublime-package/plugin/core/main.py", line 26, in plugin_loaded
    load_handlers()
  File "/Users/rafal/Library/Application Support/Sublime Text 3/Installed Packages/LSP.sublime-package/plugin/core/registry.py", line 59, in load_handlers
    register_language_handler(handler)
  File "/Users/rafal/Library/Application Support/Sublime Text 3/Installed Packages/LSP.sublime-package/plugin/core/registry.py", line 65, in register_language_handler
    config = handler.config
  File "/Users/rafal/Library/Application Support/Sublime Text 3/Lib/python3.3/lsp_utils/_client_handler/language_handler.py", line 94, in config
    self.on_settings_changed(client_config.settings)
  File "/Users/rafal/Library/Application Support/Sublime Text 3/Installed Packages/LSP-pyright.sublime-package/plugin.py", line 61, in on_settings_changed
    extraPaths.extend(self.find_package_dependency_dirs(py_ver))
  File "/Users/rafal/Library/Application Support/Sublime Text 3/Installed Packages/LSP-pyright.sublime-package/plugin.py", line 175, in find_package_dependency_dirs
    dep_dirs.remove(ST_PACKAGES_PATH)
ValueError: list.remove(x): x not in list
commented

Should mention that that was with "pyright.dev_environment": "sublime_text_33" set.

With "pyright.dev_environment": "sublime_text" there is another error:

Traceback (most recent call last):
  File "/Applications/Sublime Text 3.app/Contents/MacOS/sublime_plugin.py", line 298, in on_api_ready
    plc()
  File "/Users/rafal/Library/Application Support/Sublime Text 3/Installed Packages/LSP.sublime-package/plugin/core/main.py", line 26, in plugin_loaded
    load_handlers()
  File "/Users/rafal/Library/Application Support/Sublime Text 3/Installed Packages/LSP.sublime-package/plugin/core/registry.py", line 59, in load_handlers
    register_language_handler(handler)
  File "/Users/rafal/Library/Application Support/Sublime Text 3/Installed Packages/LSP.sublime-package/plugin/core/registry.py", line 65, in register_language_handler
    config = handler.config
  File "/Users/rafal/Library/Application Support/Sublime Text 3/Lib/python3.3/lsp_utils/_client_handler/language_handler.py", line 94, in config
    self.on_settings_changed(client_config.settings)
  File "/Users/rafal/Library/Application Support/Sublime Text 3/Installed Packages/LSP-pyright.sublime-package/plugin.py", line 59, in on_settings_changed
    py_ver = self.detect_st_py_ver(dev_environment)
  File "/Users/rafal/Library/Application Support/Sublime Text 3/Installed Packages/LSP-pyright.sublime-package/plugin.py", line 142, in detect_st_py_ver
    session = self.weaksession()
AttributeError: 'LspPyrightPlugin' object has no attribute 'weaksession'
commented

Hmm... what's the way to get workspace folders (or window) of the session if there is no weaksession for ST 3 LSP?

commented

Or maybe just remove sublime_text (and sublime_text_38) since it makes less sense that a user uses ST 3 to edit a py38 ST 4 plugin.

commented

Or maybe just remove sublime_text (and sublime_text_38) since it makes less sense that a user uses ST 3 to edit a py38 ST 4 plugin.

Fixed in st3-1.2.42.