Giters

sublimelsp / LSP-json

Schema validation/completions for your JSON and Sublime files

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Directly use the server from its source repo

jfcherng opened this issue · comments

commented

Currently, we fetch the server code from this NPM package. I propose that we should directly build the server codes from https://github.com/vscode-langservers/vscode-json-languageserver because

  • It gives us the ability to get any specific build of the server.
  • The one on NPM has not been updated for 5 months.
  • The maintainer of https://github.com/vscode-langservers/vscode-json-languageserver is not a collaborator of the NPM package. Asking those collaborators to update is annoying and they may be unresponsive.
  • We have already done that in LSP-css and LSP-html so this should be an easy move.
commented

Just tried the #37 PR, working on my side also(Linux, st build 4077)

The downside is that we won't receive automatic PR from dependabot when they release a new version to npm.
We need to check for updates manually, which is what I would like to avoid.
As you said, this npm package wasn't updated for 5 months and we do the strategy you introduced with #37 for LSP-html and LSP-css, so I am fine with merging #37.

The one thing I tried looking was opening an issue at the repo to ask them if they could make a release, but there is no issues tab. I would more like if the maintainers of the json langauge server released a new version on npm. :)

@jfcherng what would you like more? Full control but manually(periodically) do an update of getting the latest master (the responsibility is on us), or using dependabot and relaying on automatic PR(the responsibility is on the maintainer of the NPM package) but we may end up with situations like this where the package wasn't updated for a 5months.

commented

Personally I don't like a long release cycle like this. But they are just following the version number in here which comes from here. It can be just because MS hasn't increased the version number yet for 5 months.

After more digging above, I think unless we want to try a nightly build (or emergency fix somehow), we don't need #37.

As for LSP-css and LSP-html, there is no NPM package so we have no choice except to build them by ourselves. Or use those super outdated builds on NPM: vscode-css-languageserver-bin, vscode-html-languageserver-bin (considered as abandoned/unmaintained).

commented

If we can't rely on NPM package being updated regularly then I think we have no other option than updating manually from source.