stuerp / foo_vis_spectrum_analyzer

A foobar2000 component that displays a spectrum analyzer.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Bar separation doesn't take into account neighboring graphs

WagnerGFX opened this issue · comments

How it's working now:

  • Bars at the edge of a graph look visually glued with those of neighboring graphs
  • Happens at the sides as well as at the root of the bar

bar_sep_h
bar_sep_h_led
bar_sep_v
bar_sep_v_led

Expected behavior:

  • Edge bars should also be visually separated.
    • Personal Opinion: A double distance would still be better than the bars being glued.
  • Adding an option for margins between graphs could also solve this.

System Info:

  • Windows 10 22H2
  • Foobar2000 v1.6.16
  • Visualizer v0.7.2.0
  • CPU i7-2600k
  • GPU GTX 1650

Note:

  • I'm aware the requirements say Foobar2000 v2.0, but I cannot use it yet due to some components still not supporting it (mostly Spider Monkey Panel).
  • If the bug is exclusive to versions lower than v2.0, then the issue can be closed.

That is by design. You can add a margin between the graph by enabling the X-axis with or without labels. You can't set the height of the X-axis yet but it's on my To Do list.

I tested it with both X and Y axis. Y-Axis added the margin for graphs that connected at the root of the bar, but the X-Axis did not add any margin.

In the alpha1 I noticed there is a tiny gap on the root of the bars even without enabling the Y-Axis.
It's not an issue, but I just wanted to inform you in case it was not an intentional change.

Y-Axis Enabled:
vertical_with_axis

Y-Axis Disabled on alpha1:
vertical_no_axis

X-Axis Enabled:
horizont_with_axis

X-Axis Enabled on alpha1:
horizontal_2

I'll consider adding margin settings to a graph element. But not now. The render code is already becoming more complex than I anticipated.