Line overflows the dialogue box
mistydemeo opened this issue · comments
Description
The line "Hey! What are you doing?! These guys are obviously frauds! Don't help them!" has glitchy text overflowing the dialogue box and at the top of the screen.
Suggested fix
Looking at the control codes, the original dialogue box ends with the 0700 control code sequence but the unworked version ends in 0100, which I'm guessing is why it's interpreting subsequent control codes as part of the dialogue.
Screenshot (if available)
Script file (if known)
M04.GRP
Address (if known)
0x1B943
This almost certainly has to do with message ef, which opens with a segment of garbage: https://github.com/studio-lucia/lunar_eb_script/blob/84db05d19b3959df5bae69f69a1e27e5a0592dda/M04.GRP.txt#L2514-L2525
That entire message was missing when I imported this file from the unworked version, which suggests to me that something about this isn't round-tripping safely. Will look into it.
Patch generated via the current version of M04.GRP.txt produces the correct 0700 control code, so I think this is probably fixed.