Works for some text fields, but not others?
xeijin opened this issue · comments
Hello,
The extension is great when it supports a text field, but it seems to be quite temperemental about those that it does?
I don't have a good example to-hand (I am seeing the issue in the web-based tools Adobe Analytics and Adobe DTM, but guessing you wont have access to those).
As an example though, the search bar on adobe.com, and even the search bar here on Github don't work when I right-click and choose "Edit with Emacs" from the context menu in chrome.
separate question How can we get the latest version pushed to the Chrome store? I can't use the "Unpacked Extension" approach as the feature is disabled at work, alternatively if there is a way I can generate the .crx file myself, that could also work.
Thanks.
The problem with github's search box is it isn't a textarea but rather a JavaScript augmented field. Currently Edit with Emacs only understands <textarea> and <div editible=true> boxes.
As to .crx files I'm unsure what they are. The process I follow is described in https://github.com/stsquad/emacs_chrome#submitting-to-store but I don't know what Google does between there and publishing on the store. Are you waiting for a particular feature to arrive in the official version?
Thanks for the reply. Is it technically possible / on the roadmap to implement these JavaScript augmented fields?
Re. The other question - a crx file is the packaged version of the extension. I was hoping to update to the latest from GitHub, but need the extension packages in crx form in order to bring into my work environment.
Normally I can get this from the web store but I guess there hasn’t been a release to store for a while and I’m guessing I can’t release under your chrome app store details :)
Sent with GitHawk
@xeijin the last release was v1.15 in January and so far the changes have been minor. Once there are enough to justify an update I'll push another one out.
w.r.t. the roadmap it's certainly not on my radar for the foreseeable future however patches are always welcome.
here's an example where it doesn't work from the context mnu:
https://www.w3schools.com/tags/tryit.asp?filename=tryhtml_textarea
the reason is that the contextmenu event listener doesn't get triggered.
on another note, the edit button is also not displayed.
here's an example where it doesn't work from the context mnu:
w3schools.com/tags/tryit.asp?filename=tryhtml_textarea
the reason is that the
contextmenuevent listener doesn't get triggered.on another note, the edit button is also not displayed.
It works for me. Are you sure the context menu is enabled in the settings?
@stsquad strange. which browser? i'm on
$ chromium --version
Chromium 101.0.4951.41
and loading the extension from the checked out git HEAD.
it's definitely enabled because the menu is there, and it worked in other contexts while i was testing it.
but i've double checked it again just now: it doesn't work on the link above, but when i switch to my protonmail tab, there it works, even after reloading the page.
Ahh I was testing with Firefox - I can confirm Chrome is broken.
This appears to be a chrome bug that got fixed because I can confirm the context menu works now.
as another data point, this:
https://www.w3schools.com/tags/tryit.asp?filename=tryhtml_textarea
still doesn't work for me with:
$ chromium --version
Chromium 112.0.5615.165
it's not a pressing issue for me, just FYI.
Ok reopening, it seems chrome and chromium behave differently:
Google Chrome 119.0.6045.199 -> works with context menu
Chromium 119.0.6045.199 built on Debian 12.2, running on Debian 12.2 -> context menu pops editors, but no changes made
It seems to be a re-display bug. If I do multiple edits the text is what I had set it to, but the textarea display wasn't triggered
for clarity, the behavior for me is that the "Edit with Emacs" button is present in the context menu, but it does nothing. emacs is not connected.
as i noted above, once i debugged this to the point that:
the reason is that the
contextmenuevent listener doesn't get triggered.on another note, the edit button is also not displayed.