proposing a pull request for amqp queues options
ebarault opened this issue · comments
Hi,
I'd like to submit a pull request to enable straightforward support of amqplib options when creating amqp connection. Is it already wip, is there any thoughts about this, or shall i move on with this?
Purpose of this library is to allow you to switch transparently between the adapters, putting AMQP options in your code would make your code amqp specific... in which case why not just use the AMQP lib directly, since it will expose all the possible features?
ok, but why fixing options such as auto-delete:true or durable:false in the code? to what STOMP or other connector logic does this fits with ?
If you had message and queues living beyond the app, and your app depended on this, and you switched to the cluster MQ provider... your app would fail. So, now you have an app which depends on AMQP. Which is fine, but such an app should use the amqp lib directly.
I ask again, why are you using this library? Its essentially a failed experiment. It does do something, but I don't think anybody has found it useful to write apps that are so agnostic to the capabilities. What is your use-case? Why are you trying to use this lib?
Sorry, i missed your reply.
So yes, i have an app that relies on AMQP, i'm using AMQLib directly for other components of the app, and as i wanted to connect my strongloop API to my AMQP bus i discovered about the strong-mq connector. I assumed in the context of strongloop it would be more appropriate to use this connector because, again, i assumed it would directly fit with the different logics of the frameworks such as failover/retry policies, optimizations (opening the right number of connections for the whole loopback app), and so on. But reading the code i didn't see much of such an integration though.
When you say 'Its essentially a failed experiment', does it mean i won't be maintained and it is not recommended by strongloop team? If so you'd rather remove it from the documentation or indicate such a warning.
@ebarault Sorry you got misdirected, note that nothing in the docs indicates it has any integration with any framework, and it does not.