Release new version for Node v10
felixbuenemann opened this issue · comments
The master branch contains necessary changes for Node v10, it would be great to have a new version released on NPM.
I'm working on some more changes, so will release soon. I wasn't aware there was an Node.js 10 issue. What is the issue you're encountering?
It's a deprecation warning caused by iconv-lite that I had hoped would go away with the update to 0.4.22, but it looks like it will not go away due to the way they do feature-detection:
// Node authors rewrote Buffer internals to make it compatible with
// Uint8Array and we cannot patch key functions since then.
// Note: this does use older Buffer API on a purpose
iconv.supportsNodeEncodingsExtension = !(new Buffer(0) instanceof Uint8Array);So I guess there's no hurry to release a new version.
Ah. If you want to PR to that library to fix it up, and ping me here when a new version is released I can then release a new version of this module right away 👍
Opened issue ashtuchkin/iconv-lite#184 upstream.
Opened PR ashtuchkin/iconv-lite#185 to get it fixed.
Hey, the upstream PR has been merged.
Bumping to iconv-lite v0.4.23 should get rid of the remaining deprecation warning.
Nice! I will release a new raw body in a few hours as my day here is just starting 🎉
Yeah, no rush.
Btw. body-parser which seems to be maintained by you is also referencing iconv-lite 0.4.19 explicitly.
Yea, it also references this module too. I will update and publish those today too if you need those done as well.
Thanks, that would be great!