Lack of 0.8 support
Raynos opened this issue · comments
You check for stream._readableState. I still want to support 0.8
okay i'll remove it. i'm working on some other stuff right now, i'll add this and string decoder support
@jonathanong I can make pull requests for all these things if you give the go ahead.
sure, if you'd like.
@jonathanong do you prefer one larger PR or one pull request per issue ?
we can just do one.
you working on this yet? otherwise i was going to work on it now.
@jonathanong havn't started on it yet. you can do it.
all tests pass on 0.8 now. however, i didn't create any stream1s to test with. did you want to add those?
I can add those using through
i'm also not sure how to get the stream's encoding in 0.8. do you know?
wait, the tests still passed. is ._readableState in 0.8 too?
@jonathanong ._readableState does not exist in 0.8
0.8 streams have no notion of encoding baked into them. 0.8 http request streams do have a notion of encoding.
yay! 1.1.0