"Error: stream encoding should not be set"

Question

"Error: stream encoding should not be set"

opened this issue 11 years ago · comments

Throwing this error from line 48 of index.js (raw-body version 1.1.1):

Error: stream encoding should not be set
    at makeError (/my/app/node_modules/express/node_modules/connect/node_modules/raw-body/index.js:132:15)
    at /my/app/node_modules/express/node_modules/connect/node_modules/raw-body/index.js:48:17
    at process._tickCallback (node.js:415:13)

Value of stream.encoding is undefined, rather than null, which it is expecting. Updated line to read the following and everything seems to work great:

if (state && state.encoding !== null && state.encoding != undefined)

jongleberry · Answer 1 · Mon Dec 02 2013 04:15:14 GMT+0800 (China Standard Time)

ohhhhh that makes sense.

jongleberry · Answer 2 · Mon Dec 02 2013 04:16:15 GMT+0800 (China Standard Time)

i'll do that, but why do you know why it is set as undefined?

Kirk Morales · Answer 3 · Mon Dec 02 2013 04:17:54 GMT+0800 (China Standard Time)

Not sure - it's being used by ExpressJS like that. I'm just including express in my app.

jongleberry · Answer 4 · Mon Dec 02 2013 04:19:10 GMT+0800 (China Standard Time)

what platform are you on? i'm bumping connect and express now

Kirk Morales · Answer 5 · Mon Dec 02 2013 04:20:18 GMT+0800 (China Standard Time)

SunOS 5.11 i86pc i386 i86pc Solaris

jongleberry · Answer 6 · Mon Dec 02 2013 04:20:41 GMT+0800 (China Standard Time)

oh, something i know nothing about.

Kirk Morales · Answer 7 · Mon Dec 02 2013 04:21:40 GMT+0800 (China Standard Time)

It's an instance on Joyent

jongleberry · Answer 8 · Mon Dec 02 2013 04:23:36 GMT+0800 (China Standard Time)

fixed and pushed to connect/express. if you guys can figure out when it's set as undefined, that would be great! i'll leave this issue open just for that.

Kirk Morales · Answer 9 · Mon Dec 02 2013 04:27:26 GMT+0800 (China Standard Time)

Thanks! I did notice that this seems to only be an issue with an https server. When I run in an environment with SSL off, there are no problems.

Dan Polivy · Answer 10 · Tue Dec 03 2013 01:35:05 GMT+0800 (China Standard Time)

Seeing the same issue here, running Node v0.10.4 on Windows, with iisnode as the front-end. It happens only on POST requests (with a body to parse). The incoming request is coming in via SSL, though the SSL terminates at IIS and it is passed to iisnode as a HTTP request (with X-Forwarded-For headers). My code never calls req.setEncoding() -- though I can't vouch for express/connect middleware that may run before mine.

jongleberry · Answer 11 · Tue Dec 03 2013 03:25:34 GMT+0800 (China Standard Time)

Did the latest version fix your problem?

Kirk Morales · Answer 12 · Tue Dec 03 2013 03:26:00 GMT+0800 (China Standard Time)

Fixed it for me.

Dan Polivy · Answer 13 · Tue Dec 03 2013 05:25:01 GMT+0800 (China Standard Time)

Yes, it appears to be fixed in express 3.4.6/raw-body 1.1.2.

jongleberry · Answer 14 · Wed Dec 04 2013 19:06:34 GMT+0800 (China Standard Time)

so i guess it's something with SSL. i'll keep this issue open until i (or someone else :D) adds a test for it.

Adam Platt · Answer 15 · Sat Dec 14 2013 05:33:56 GMT+0800 (China Standard Time)

Updating from express 3.4.5 to 3.4.7 solved this issue for me as well. Just wanted to add that in my case everything was fine when running locally on my Mac, but I started getting the error once I published to Windows Azure.

In case it's of any use, the project I am working on is located here on GitHub https://github.com/platta/picstream (if you view any of my code, don't judge me too harshly - I'm new to node.js :) ).

Douglas Wilson · Answer 16 · Tue May 27 2014 13:15:03 GMT+0800 (China Standard Time)

So the official answer is there was no state.encoding property until node.js v0.10.6 (added in commit nodejs/node-v0.x-archive@bdb78b9). Thus state.encoding was always undefined before that version :)