strawdynamics / luminous

A simple, lightweight, no-dependencies JavaScript lightbox

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Support for ix-src and sizes attributes on <img>

ku1ik opened this issue · comments

I use both imgix.js and Luminous, they work great. It would be even more awesome if Luminous/LuminousGallery could make use of ix-src / srcset and sizes attributes so the full images displayed in lightbox could be loaded in size proper for a given device. Right now I'm requesting 1920x1080 version but this makes little sense when lightbox is opened on a mobile phone.

Is this something you planned? Or maybe there's a way to achieve that today?

Hey @sickill 👋

Fred here from Imgix. From today I'm responsible for the maintenance of this repo. I'm not quite aware of the specifics around ix-src, but it seems reasonable for this library and imgix.js to work well together. Right now we're focussing on bugs and documentation, but I'll make sure to have a look at this when we get around to enhancing this repo.

Is this still a useful feature for you? Imgix.js went through a large API change recently, so I'd just like to check that it's still useful.

It's been almost 2 years since I opened this issue and I'm not using imgix.js right now. Feel free to close the issue 👍

Thanks for the feedback @sickill. We'll keep this open as it looks like it's a useful feature for the future 👍

Closing this issue as it is quite old but I have noted this idea in our backlog for future consideration.