storybookjs / test-runner

🚕 Turn stories into executable tests

Home Page:https://storybook.js.org/docs/writing-tests/interaction-testing

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Remove filterered stories from test

zb-sj opened this issue · comments

My sub test only needs one story to test but the current tag filtering implementation creates redundant describe.skip(${title}, () => { it('no-op', () => {}) }); as per makeDescribe

It wastes noticeable time just to skip those tests.

Wouldn't it be better not to generate a description for filtered tests? I see there is skipTags for the exact purpose.

Please let me know what you think and I could probably make a quick PR for this.

Hey there! I'd appreciate a PR. If I recall correctly, it was not possible to do this because of file transformation limitations.

If I recall correctly, it was not possible to do this because of file transformation limitations.

I will have a look, but don't get hopes so high since you would know better than me :)

It's been a while but I'm sorry I haven't had much time to look into this. 😢

Please feel free to close this issue for now. I will reopen when I start the work.