[Feature Request] Support of Svelte 4

Question

[Feature Request] Support of Svelte 4

oscard0m opened this issue a year ago · comments

Describe the feature

Is there a plan to support Svelte 4? I would be happy to help with this if possible.
Storybook has an alpha release in the oven where it will support Svelte v4: storybookjs/storybook#23197

Additional context

https://svelte.dev/blog/svelte-4

Jeppe Reinhold · Answer 1 · Mon Jul 03 2023 18:13:12 GMT+0800 (China Standard Time)

I'd be happy to take a look at any PRs adding support for Svelte 4. At the minimum we'd need to bump the versions of svelte and related packages in package.json, similar to what storybookjs/storybook#23197 does. We might need to do more than that, I'm unsure.

Wilhelm Bartel · Answer 2 · Tue Jul 04 2023 19:02:41 GMT+0800 (China Standard Time)

it looks like there is a bit more to do:

I tried to simply update it, but it looks like the @storybook/svelte-webpack5 still requires svelte v3.

The only reference to that module in this project that I can find is in the storybook main.js. Shouldn't it be possible to completely remove this module and use the "standard" vite way of bundling instead of webpack?

Jeppe Reinhold · Answer 3 · Thu Jul 06 2023 17:08:56 GMT+0800 (China Standard Time)

Thanks for trying @RSWilli !

The fact that @storybook/svelte-webpack5 still only supports Svelte 3 is an error upstream - by me. I need to update that as well.
That dependency is only used for the internal Storybook to test out the features in this project, it's not used for the actual bundling. I'd be happy for anyone to replace it with @storybook/svelte-vite, it should be doable. I'm not exactly sure why the stuff in webpackFinal is needed, maybe it wouldn't be needed in a Vite based setup, or maybe we need to port it over to the Vite equivalent.

Wilhelm Bartel · Answer 4 · Thu Jul 06 2023 20:03:43 GMT+0800 (China Standard Time)

That's what I suspected, I am going to try again, since addon-svelte-csf is the only dependency that blocks the update to svelte 4 in my repositories.

Jeppe Reinhold · Answer 5 · Thu Jul 06 2023 20:19:38 GMT+0800 (China Standard Time)

FYI storybookjs/storybook#23336

Wilhelm Bartel · Answer 6 · Thu Jul 06 2023 21:18:05 GMT+0800 (China Standard Time)

I give up again. I tried, but with the vite loader I am getting errors that I cannot explain. Aka: some of the webpack stuff seems to do something

After your PR it should be easier to update this repo though.

Rory Fuhrer · Answer 7 · Fri Jul 14 2023 07:15:50 GMT+0800 (China Standard Time)

@RSWilli Storybook has been updated to support svelte 4 now (https://github.com/storybookjs/storybook/releases/tag/v7.0.27) if you wanted to give it another shot. I'm also seeing an issue with HMR where if you change a story the HMR refresh will overwrite all template args with the args from the last story. But I didn't want to raise that issue until this addon properly supports svelte 4

Wilhelm Bartel · Answer 8 · Fri Jul 14 2023 15:28:27 GMT+0800 (China Standard Time)

@rory-orennia I'm at it, although I will not do anything about the HMR issue you mentioned

Rory Fuhrer · Answer 9 · Fri Jul 14 2023 23:08:48 GMT+0800 (China Standard Time)

@rory-orennia I'm at it, although I will not do anything about the HMR issue you mentioned

My hope was that it's caused by the outdated dependencies. I'll raise the issue after this is merged if it still exists

Michael Shilman · Answer 10 · Wed Jul 19 2023 14:53:02 GMT+0800 (China Standard Time)

🚀 Issue was released in v3.0.4 🚀