New parser implementation should accept numbers for the `default` placeholder option.
peterhuene opened this issue · comments
See discussion here.
While I am of the opinion that only a string value should be accepted for the default placeholder option, an official parser does accept numbers as well.
That might be reason enough to support it in our implementation too.
First things first:
In fact, I think we should be linting the use of placeholder options as part of the "deprecation" rule.
Fully agree. I don't think that's controversial (at least among our team). There are other lints I'd put ahead of this on a priority list, but definitely want to see a Deprecated lint implemented before any v1-type of release.
But on to the actual issue here: thanks for the thorough write up in the other thread.
Given that placeholder options are deprecated and there were only a few occurrences of not using a quoted value in the gauntlet run, I was thinking the current behavior and a "c’est la vie" approach would be best here.
I'm inclined to agree. Especially given that our new parser is infallible (👏 ) and the rest of the document can still be parsed/linted/etc. I vote we leave it as is, unless someone complains and asks us to "fix" this case. I just think it's such a niche issue it isn't worth the bandwidth to fix.