[documentation] Documentation of "last" parameter default doesn't match code
kepstin opened this issue · comments
Calvin Walton commented
In the current version of the README, the last
option is documented as having a default of true
:
Property | Type | Default | Description |
---|---|---|---|
last |
boolean | true | Whether the stroke is complete. |
However, in the code - getStrokeOutlinePoints
and getStrokePoints
- the actual default of the last
option (assigned to the isComplete
variable) is set to false
.
I'm not sure what the intention is here, but to preserve the behaviour of the library it might be best to leave the default as false
and update the documentation to match.
Steve Ruiz commented
Fixed! Thank you.