Giters

stevenvachon / minurl

Reduce and normalize the components of a WHATWG URL.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

An in-range update of whatwg-url is breaking the build 🚨

greenkeeper opened this issue · comments

commented

Version 6.1.0 of whatwg-url just got published.

Branch Build failing 🚨
Dependency whatwg-url
Current Version 6.0.1
Type devDependency

This version is covered by your current version range and after updating it in your project the build failed.

As whatwg-url is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Status Details
  • ❌ continuous-integration/travis-ci/push The Travis CI build failed Details
Release Notes 6.1.0

Made the scheme setter properly reset the port as appropriate, per whatwg/url@0f53958.

Commits

The new version differs by 4 commits.

  • ebc0b39 6.1.0
  • 07d09a4 Update current status
  • 4a2c894 Remove deprecated use of new Buffer()
  • 1ea1209 Spec update: normalize port after updating scheme

See the full diff

Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.

Your Greenkeeper Bot 🌴

commented

After pinning to 6.0.1 your tests are still failing. The reported issue might not affect your project. These imprecisions are caused by inconsistent test results.