Config documentation clarification

Question

Config documentation clarification

shazoom opened this issue 7 years ago · comments

The distinction between US and UK language is based on the Echo being used, I think. I have a UK google music account but a US Dot using US english (and I'm in Brunei.) This, basis for following different instructions (the language of the Echo) isn't very clear from the docs.

I followed instruction for the US configuration (with Heroku) which I expected to fail (because I have a UK google music account) but were so much simpler I thought it was worth a try. Slightly surprised to find it worked 😊

Sam Turner · Answer 1 · Sat Jun 10 2017 22:19:43 GMT+0800 (China Standard Time)

I think the current information is correct

This Skill was developed to only work on English (US) language devices.

(I maybe a bit biased as I wrote it 😄 )

Which is kinda what you are saying "The distinction between US and UK language is based on the Echo being used, I think."

Maybe you didn't spot it in the notes section?

shazoom · Answer 2 · Sat Jun 10 2017 22:31:39 GMT+0800 (China Standard Time)

I think the current information is correct This Skill was developed to only work on English (US) language devices. (I maybe a bit biased as I wrote it 😄 )

I’m sure you are correct. The bit I’m referring to really is a bit later under “Interaction model”. Perhaps instead of "US English Users" you might consider “Echo set to use US English”. Actually, I really like your documentation and it’s really quite easy to get it running.

Which is kinda what you are saying "The distinction between US and UK language is based on the Echo being used, I think." Maybe you didn't spot it in the notes section?

I think I skimmed over that part. As the note is currently only important for the interaction model you might consider moving it there. Anyway, great work and thanks for sharing.

Sam Turner · Answer 3 · Sun Jun 11 2017 19:22:44 GMT+0800 (China Standard Time)

Thanks, but I can't the credit. All I did was update the docs and cobbled together the UK workaround. I will add the clarification, but steven will have to merge it

steve gattuso · Answer 4 · Tue Jun 13 2017 04:45:15 GMT+0800 (China Standard Time)

Just merged it in. Is there anything else that needs to get done here or is this issue good to close?

shazoom · Answer 5 · Wed Jun 14 2017 09:39:34 GMT+0800 (China Standard Time)

It looks good to me 😊

Adam Jones · Answer 6 · Tue Aug 22 2017 08:22:34 GMT+0800 (China Standard Time)

Over two months after merge, close this issue?

shazoom · Answer 7 · Tue Aug 22 2017 14:45:14 GMT+0800 (China Standard Time)

Apologies if you were waiting on input from me. Yes.

On Tue, 22 Aug 2017, 08:22 Adam Jones ***@***.***> wrote: Over two months after merge, close this issue? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#100 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AB_junkSEwTu_-bIsYyw0vjKNhIwtFMmks5sah9MgaJpZM4N2Hk6> .

-- Please excuse any typos or auto-correct-ups which I will make, I am sorry for any offence that they will cause, they will have been typed on phone using a virtual keyboard with autocorrect.