stevenfontanella / microlens

A lightweight (but compatible with ‘lens’) lenses library

Home Page:https://hackage.haskell.org/package/microlens

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

microlens-th fails to build against microlens 0.4.10

hpdeifel opened this issue · comments

cabal unpack microlens-th
cd microlens-th-0.4.3
cabal new-build --constraint 'microlens ==0.4.10'
Resolving dependencies...
Build profile: -w ghc-8.6.3 -O1
In order, the following will be built (use -v for more details):
 - microlens-th-0.4.3 (lib) (configuration changed)
Configuring library for microlens-th-0.4.3..
Preprocessing library for microlens-th-0.4.3..
Building library for microlens-th-0.4.3..
[1 of 1] Compiling Lens.Micro.TH    ( src/Lens/Micro/TH.hs, somewhere/microlens-th-0.4.3/dist-newstyle/build/x86_64-linux/ghc-8.6.3/microlens-th-0.4.3/build/Lens/Micro/TH.o ) [Lens.Micro.Internal changed]

src/Lens/Micro/TH.hs:84:1: error:
    Lens.Micro.Internal: Can't be safely imported!
    The module itself isn't safe.
   |
84 | import           Lens.Micro.Internal (phantom)
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

I only noticed this because some package in my dependency tree depends on microlens<0.4.11 and consequently my CI stated failing.

commented

Thanks! I'm going to revert the assignment of Trustworthy status to Lens.Micro.Internal – after further investigation it looks kinda shady. I will also deprecate affected versions and make patch releases.

commented

Done.