wrong port number in readme
jovrstra opened this issue · comments
Very small issue:
The readme file on line 137 (First Steps) refers to port 8080 rather than 8180.
:-)
@jovrstra Why not fix it in a pull request?
Not sure how to do it that way.... probably I misinterpreted what pull request means.. I haven't used Github that much. :-)
I'm not planning to develop, I don't need to pull the repository and create a branch... I just needed to install SteVe (in Docker) and wanted to inform about a small thing in the readme.
In that case, just go to https://github.com/steve-community/steve/blob/master/README.md and click on
Also requires me to fork it...
Let's just drop it... I just wanted to help.
... refers to port 8080 rather than 8180.
the sentence is "The default port number is 8080." it does not say that your port will be 8080. indeed, dev prod and test profiles use 8080. docker and k8s use 8180. and if you change the port (whatever the profile), it does not make this sentence less true, because you changed the default. you diverged from default.
at best, i would remove this line completely.