feature : support open metrics exemplars

Question

feature : support open metrics exemplars

camerondavison opened this issue 2 years ago · comments

Cameron Davison commented 2 years ago

https://github.com/OpenObservability/OpenMetrics/blob/main/specification/OpenMetrics.md#exemplars-1

https://github.com/prometheus/client_python/blob/f17a8361ad3ed5bc47f193ac03b00911120a8d81/README.md#exemplars

Would it be reasonable to have optional dependencies on open telemetry to get the trace info for a bucket?

Steve Hillier · Answer 1 · Sat Oct 01 2022 22:00:06 GMT+0800 (China Standard Time)

Yes, that sounds reasonable, and I’m definitely interested in this feature.

…

On Sat, Oct 1, 2022 at 5:21 AM Cameron Davison ***@***.***> wrote: https://github.com/OpenObservability/OpenMetrics/blob/main/specification/OpenMetrics.md#exemplars-1 # TYPE foo histogram foo_bucket{le="0.01"} 0 foo_bucket{le="0.1"} 8 # {} 0.054 foo_bucket{le="1"} 11 # {trace_id="KOO5S4vxi0o"} 0.67 foo_bucket{le="10"} 17 # {trace_id="oHg5SJYRHA0"} 9.8 1520879607.789 foo_bucket{le="+Inf"} 17 foo_count 17 foo_sum 324789.3 foo_created 1520430000.123 Would it be reasonable to have optional dependencies on open telemetry to get the trace info for a bucket? — Reply to this email directly, view it on GitHub <#57>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AGOSDMOGNAJYCV34C4HDNWDWBAUDJANCNFSM6AAAAAAQ2NXXYY> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

Cameron Davison · Answer 2 · Sat Oct 01 2022 22:57:05 GMT+0800 (China Standard Time)

I just read that

Exemplars are not supported

For multi process mode. That is a bummer. I wonder how much work it would be to fix the prom client.

Cameron Davison · Answer 3 · Sat Oct 01 2022 23:00:02 GMT+0800 (China Standard Time)

prometheus/client_python#826

Steve Hillier · Answer 4 · Mon Oct 03 2022 05:37:56 GMT+0800 (China Standard Time)

That's too bad, would that be a deal breaker for you? I might work on adding support for exemplars in single process mode anyway (unless you already wanted to submit a PR)

Cameron Davison · Answer 5 · Mon Oct 03 2022 06:26:37 GMT+0800 (China Standard Time)

I don't have a pr yet. It would be a deal breaker for me. But if you add support I assume it will work when they add the support

Steve Hillier · Answer 6 · Mon Jan 16 2023 07:22:19 GMT+0800 (China Standard Time)

Added in #58 - unfortunately prometheus_client seems to still not support exemplars for multiprocess mode. Closing as done since exemplars were added here and it should work for anyone not using multiprocess mode. Hopefully support is added soon.