stephenhillier / starlette_exporter

Prometheus exporter for Starlette and FastAPI

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Better naming

intelroman opened this issue · comments

Waiting proposal for naming .. on optional_metrics
Now we have 2 optional metrics
request_response_body_size => how much bytes the server send back to the client.
client_receive_body_size => how much data receive server from client (post/put)

It will be great to have a better naming .

What do you think about response_body_bytes and request_body_bytes?

Yes this make sense.
I will update the naming.
Thank you Stephen.

thanks @intelroman! merged your changes in #43