Giters

stephenafamo / bob

SQL query builder and ORM/Factory generator for Go with support for PostgreSQL, MySQL and SQLite

Home Page:https://bob.stephenafamo.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[psql] Issues with window functions

relvacode opened this issue · comments

commented

The window argument to Function.Over is unused.
https://github.com/stephenafamo/bob/blob/main/dialect/psql/dialect/function.go#L76

Additionally, OVER () with an empty window definition is a valid statement, at least for PostgreSQL but is currently not possible due to wr.def.Valid()
https://github.com/stephenafamo/bob/blob/main/dialect/psql/dialect/function.go#L122