stephane-r / holoplay-pwa

Web app using Invidious API for listening Youtube audio source.

Home Page:https://app.holoplay.io

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Trending has music charts

maboroshin opened this issue · comments

It would be useful to have an automatically retrieved local country and English.

Alternatively, Invidious can simply set a 2-letter country name.

Mmm, not sur to undestand your request. It's for trending API ?

If you are interested in creating this feature, I want use it. I had no idea how Holplay worked. Sorry.

https://app.holoplay.io/trending : This Trending page has many normal videos (Non-music videos). But Holoplay is for music. It would be good to show Trending of music.

  1. Show "Trending in US Music". This Trending for US is always available.
  2. Country code can be select from the drop-down menu. This Trending is for country selection.
  3. Get country code from browser etc. and set it automatically for country selection.

About Country code. Invidious Instance has a drop-down menu for country selection.
image


You said Invidious API. I found the following this API:
/API/V1/TRENDING, type: "music", region: (default: "US")

Yes ok i see 😄 It's good idea for region and music type ! I think get the user region with JS API and set it by default. User can be update region by using dropdown menu.

I'll add it soon 👍

@maboroshin added in next release 1.5.0

@stephane-r Thanks. Very nice.

Perhaps the variable name is missing.

&region=JA : This was the initial value obtained automatically. If this changed to jp, It displayed correctly.


Browser:
image

Browser's Dev tools:
image

Can you re-try on 1.5.1 version ?

If not fix, can we see this problem on Jitsi/Discord/other ?

Thank again @maboroshin

@stephane-r It's not fixed. 1.5.0 was show error message on only a trending page. In 1.5.1, all pages are blank screens include the trending page: https://app.holoplay.io/trending

image


alert(navigator.language) : return ja (Chrome and Firefox on Windows)

My Jitsi now : https://meet.jit.si/IronicNewspapersPortrayTonight (No mic/camera)

From the first site, I have listed the country codes with only 2 language code characters. Moved the same country code and language code to the second list. Lines with comment had multiple same language codes.

Mismatch
af-ZA
ar-EG // Egypt: Population is large
be-BY
ca-ES
cs-CZ
cy-GB
da-DK
dv-MV
el-GR
en-US // United States
et-EE
eu-ES
fa-IR
gl-ES
gu-IN
he-IL
hi-IN
hy-AM
ja-JP
ka-GE
kk-KZ
kn-IN
ko-KR
ky-KG
mi-NZ
mr-IN
ms-MY // Malaysia
nb-NO
nn-NO
ns-ZA
pa-IN
ps-AR
qu-PE // Peru: Peru is famous, maybe
sa-IN
se-NO // Norway: tentative
sq-AL // Albania
sv-SE // Sweden
sw-KE
ta-IN
te-IN
tl-PH
tn-ZA
tt-RU
uk-UA
ur-PK
vi-VN
xh-ZA
zh-CN // China
zu-ZA
Same
az-AZ
bg-BG // Bulgaria
de-DE // Germany
es-ES // Spanish
fi-FI
fo-FO
fr-FR // France
hr-HR // Croatia
hu-HU
id-ID
is-IS
it-IT
lt-LT
lv-LV
mk-MK
mn-MN
mt-MT
nl-NL // Netherlands
pl-PL
pt-PT // Portugal
ro-RO
ru-RU
sk-SK
sl-SI
th-TH
tr-TR
uz-UZ
Language code only
eo
ts

It's displayed correctly with 1.5.2.

What do you think of the checkbox named US? If this is on, then become force "region=US". It is useful for displaying international chart.

image

Hi @maboroshin

Why add US checkbox and not select the US region from list ?

It takes more than 5 seconds. I mainly look at Japan and US charts.
If this usage is not reasonable, Please reject this idea.