[Bug]: syntaxerror: Left side of assignment reference
sbhehe233 opened this issue · comments
What happened?
followed the bun sample (docs/integration/bun.md) and ran into the below syntax error
Tried both 1.12 and 2.0.0 and had the same outcome
What did you expect to happen?
Tests should run as expected
Version
1.12
Environment
Bun v1.026
How can we reproduce this bug?
Run the official bun sample (docs/integration/bun.md) with Bun v1.026
Relevant log output
No response
Would you be interested in working on a bugfix for this issue?
- Yes! Assign me
Hey, thanks for starting the issue!
It's a known issue with Bun, not related to Step CI.
Hey, thanks for starting the issue!
It's a known issue with Bun, not related to Step CI.
fair enough but shouldnt this be noted in the sample? ppl would think it’s supported while actually it isnt yet …
Yes, I think we should mention it in the docs. Can you contribute a fix to the doc?
It's a known issue with Bun
was there an open bug in bun before this one? sorry if it was missed. this seems to be a very trivial parser bug:
(a?.b)[1] = 2;
minimized from this line
(stepResult.checks?.messages)[check.id] = {
the optional chain is not handled by bun. i think we can fix this easily but i'm currently wrapped up in a lot of windows compat work.
Sorry, I meant that this is known issue among Step CI users using Bun, not Bun's issue in particular.
I'm not sure how the fix would look like.
Also, keep in mind that got
, the library used by Step CI also does not work with Bun: oven-sh/bun#3150
ah. got
would be the next blocker after this, not just the simple parsing bug.
i think it is reasonable to add in your docs that bun support is blocked by these issues (can open a new issue in bun specifically for stepci to link, and that issue should point to got+the parsing bug). it is our responsibility to fix these all.
Will do! Really value your effort in helping Step CI run in Bun. Thanks for coming by 😃
Yes, I think we should mention it in the docs. Can you contribute a fix to the doc?
Sure here would probably be best?
stepci/docs/integration/bun.md
Line 4 in a168992
Yes!
Now this has been taken care of with bun 1.0.27 but a new issue has occurred unfortunately… will follow up with another thread cheers